NISystemsEngineering / LabVIEW-Modbus-API

63 stars 37 forks source link

re-work serial code back to cleaner implementation + small fixes #4

Closed smithed closed 5 years ago

smithed commented 5 years ago

I don't think you want to merge this for a while until its been tested more than just on my machine, but I wanted to make a pull request so its here. The commits are documented as to what they do, with my key comments being: The readme says the code is 2014, its actually 2012. I don't have 2012, so I used 2013. 95f6632 depends on acfd584 since they both touch the serial code, but 95.. is a tiny change that can and should be fixed in the master if you don't merge the full request. 6b.. and 7a.. can be cherry picked to resolve those issues. Only the serial changes are major.

agomez08 commented 5 years ago

@becega

I tested smithed's branch and it works fine.

I don't have any concern with approving this pull request. Thanks!

becega commented 5 years ago

@smithed , @agomezNI Thanks just accepted the pull request and its building. I will send it this week to tools network.