search

NIT-Hamirpur-NITH / ProxyHelper

This repository will contain the code for a cool application that would remove the need to use FoxyProxy and likes.
8 stars 11 forks source link

nicer readme, auto tor-pinging, way to test if it is really working #14

Closed clearnote01 closed 8 years ago

Akarshit commented 8 years ago

@clearnote01 Great work. The PR looks awesome. Though I would like to point out that you could perhaps pay a little more attention to the commit message. I saw a couple of those had git add . in them. You might want to read this for that

clearnote01 commented 8 years ago

Yeah... I know when I was using git commit -m "" I forgot closing quotes a few times and commit messages had that 'gitadd .' added to them somehow(?_?) I'll be more careful from now, but the link you gave, it discourages changing commit that are already pushed to remote, so i won't be changing older messages. I will delete the torpinger_old.py file.