search

NITDgpOS / Fearch

This is a chrome extension where we can search music,video and books over ftp servers. You can add it to your chrome using this link -
https://chrome.google.com/webstore/search/fearch
MIT License
37 stars 37 forks source link

Fixes #107 : Add gif of the extension #108

Closed akshatnitd closed 6 years ago

akshatnitd commented 6 years ago

Add a gif on Readme with demo

akshatnitd commented 6 years ago

@djmgit @PaliwalSparsh Please review :)

PaliwalSparsh commented 6 years ago

@akshatnitd Actually you just need to add the .gif or jpeg in the comments of your PR. Anyway thanks 😄

akshatnitd commented 6 years ago

@PaliwalSparsh I had purposely added it in the README for the users to see the UI of the extension on the README itself

PaliwalSparsh commented 6 years ago

@akshatnitd I see you created an issue #107 but you didn't reference to it properly. You have done it as a fixes #106 which is your other PR. No issues I will reopen this, you can fix #106 PR and update this PR.

Thankyou

akshatnitd commented 6 years ago

@djmgit @PaliwalSparsh Added the new gif. Do check :)

akshatnitd commented 6 years ago

@PaliwalSparsh Made the changes. Included address bar in the gif and compressed it to 960kb

PaliwalSparsh commented 6 years ago

@akshatnitd you can merge on your own I guess now XD but it's always better to get it reviewed. Anyways thanks for the PR 😄