search

NITDgpOS / Fearch

This is a chrome extension where we can search music,video and books over ftp servers. You can add it to your chrome using this link -
https://chrome.google.com/webstore/search/fearch
MIT License
37 stars 37 forks source link

Change the description of the extension #11

Closed akshatnitd closed 7 years ago

ananyo2012 commented 7 years ago

@akshatnitd Happy to get your first PR :smile: We will be reviewing it soon. Just to make aware of the best practices always write a commit message mentioning the issue no and a statement like Fixes #11. That way we will able to link to that issue and it will easier for us to review your PR

akshatnitd commented 7 years ago

@ananyo2012 Will keep that in mind :)

ananyo2012 commented 7 years ago

@PaliwalSparsh Please review and merge

PaliwalSparsh commented 7 years ago

@akshatnitd Thanks for the PR I will have a look at it by tonight 😄

akshatnitd commented 7 years ago

@PaliwalSparsh Great !

PaliwalSparsh commented 7 years ago

@akshatnitd How about we also include the name of affected file in the commit message. "manifest: Change the description of the extension" This is a great practice and is used by some good projects out there. As by only looking at the commit message we can find where the changes have been made.

So please can you amend the change

  1. git commit --amend Text editor opens and shows the commit there change the commit message and save the file. Change has been made to previous commit.
  2. git push -f This is a force push (-f) as you had already pushed a commit to overwrite it we need to do a force push. You can read more about it.

That's all congrats you also learned how to amend a commit message. Amend can be used to update or change your last commit, here we are using it for only changing the commit message. 😄

akshatnitd commented 7 years ago

@PaliwalSparsh Thanks, new command learnt :smile: Made the suggested changes.

PaliwalSparsh commented 7 years ago

There you go congrats for the first PR.

akshatnitd commented 7 years ago

:smile: