Fixes #111 : Add gear icon for opening options page

NITDgpOS / Fearch

This is a chrome extension where we can search music,video and books over ftp servers. You can add it to your chrome using this link -

https://chrome.google.com/webstore/search/fearch

MIT License

37 stars 37 forks source link

Fixes #111 : Add gear icon for opening options page #118

Closed akshatnitd closed 6 years ago

akshatnitd commented 7 years ago

@djmgit @PaliwalSparsh Please review :)

PaliwalSparsh commented 7 years ago

@djmgit Oh I am really sorry was busy with work overlooked this. I need to look at this, please can you let me know of any tradeoffs for not using API. Also, is this a common practice and would not produce any unintended results even when used in production. Would i be able to access the page by right-click "Options" if i dont use API ?

djmgit commented 7 years ago

@PaliwalSparsh I don't think there will be any problem. You can always open options page manually by clicking options (chrome) and about:addons (firefox). I guess we can merge this and check if it causes any error in future.

PaliwalSparsh commented 6 years ago

@djmgit @akshatnitd Sorry for the delay 😞 I was not getting a chance to check it. Thankyou for the PR