fix issue #18, #17 and #10 - Githubissues

NITDgpOS / Fearch

This is a chrome extension where we can search music,video and books over ftp servers. You can add it to your chrome using this link -

https://chrome.google.com/webstore/search/fearch

MIT License

37 stars 37 forks source link

fix issue #18, #17 and #10 #20

Closed nkprince007 closed 7 years ago

nkprince007 commented 7 years ago

Issue #10

linter es:lint

Issue #18

error display with no option selected

Issue #17

warning upon empty query

sonalkr132 commented 7 years ago

Great work @nkprince007 :+1:

Can you please send us three separate PRs for each of the fix? It is better to deal with one issue in one PR. Looks like you have already sent one https://github.com/NIT-dgp/chrome-search-extension/pull/19.

You might find cherry-pick useful[1][2].

[1] https://git-scm.com/book/ch5-3.html#_rebase_cherry_pick [2] https://ariejan.net/2010/06/10/cherry-picking-specific-commits-from-another-branch/