search

NITDgpOS / Fearch

This is a chrome extension where we can search music,video and books over ftp servers. You can add it to your chrome using this link -
https://chrome.google.com/webstore/search/fearch
MIT License
37 stars 37 forks source link

Add files via upload #60

Open spidervamsi opened 7 years ago

spidervamsi commented 7 years ago

These 3 files have been changed for " I'm feeling lucky button in chrome extension"

abhay-raizada commented 7 years ago

@PaliwalSparsh is travelling maybe @djmgit should have a look at it if he's available? @spidervamsi It might take some time to review :P

spidervamsi commented 7 years ago

I'll wait for him.Thank you so much @abhsag24 :)

PaliwalSparsh commented 7 years ago

@djmgit thanks for reviewing.

@spidervamsi Thanks for the PR. As @djmgit specified this is issue #35 . The bug had needs design label so we could have had a discussion before working on the PR. But now you have sent the PR so no problem with that. Just develop a habit to comment on PR before working on it.

As i can see from the changes you made, I'm feeling lucky button here directs us to the google doodle pages. That's great you added the button that is first part done right, just make sure to add the changes as specified by djmgit.

Next and the most important thing you would want to do is search for a way through which we can create a URL that lands us on the first result of the google results query (ie actual work that I'm feeling lucky does). Once you find the URL that would be used to perform this work, add the search query to it and then add this whole to the button. That would do the work.

I hope you would be able to make it work. Again thanks for the work.