search

NITDgpOS / Fearch

This is a chrome extension where we can search music,video and books over ftp servers. You can add it to your chrome using this link -
https://chrome.google.com/webstore/search/fearch
MIT License
37 stars 37 forks source link

Issue #78 solved #79

Closed vishvanath45 closed 7 years ago

vishvanath45 commented 7 years ago

Changed chrome-search-extention in the first line of How to Contribute section to Fearch.

PaliwalSparsh commented 7 years ago

@vishvanath45 Thansk for the PR 😄 I guess you didnt update repo before making the change and as a result commit from iamrishab07 is also showing. Do a git rebase -i HEAD ^^ and keep only your commit. Remove the commit from iamrishab07 and do a git push -f

PaliwalSparsh commented 7 years ago

Also please have a look at CONTRIBUTING.md on how to make a commit message.

image

abhay-raizada commented 7 years ago

@vishvanath45 nice rebase :P you still need to follow the commit structure shortlog is the commit message where u specify in short what change you made. It should be very short. Commit body is where u explain in detail. And in the body we put the Fixes issue tag

abhay-raizada commented 7 years ago

@vishvanath45 i approve this PR you can go ahead and write your proposal @PaliwalSparsh will merge it whenever he's free :D

PaliwalSparsh commented 7 years ago

@vishvanath45 Thanks great work. Looking forward for your proposal.