search

NITDgpOS / UIP

A library, to customize your desktop wallpapers.
https://nitdgpos.github.io/projects/UIP
GNU Affero General Public License v3.0
19 stars 45 forks source link

Add utils folder, differentiate, setup-utils, and regular utils #234

Closed hackrush01 closed 7 years ago

hackrush01 commented 7 years ago

Made a new folder utils in uiplib, and added the setup required methods in setupUtils.py and others are kept unchanged in utils.py only.

Fixes #224

abhay-raizada commented 7 years ago

@hackrush01 can you rebase away the previous commit that doesn't belong to this PR

hackrush01 commented 7 years ago

Is this what you wanted?

abhay-raizada commented 7 years ago

@hackrush01 the last commit, yes pretty much :D

hackrush01 commented 7 years ago

I have no idea about rebasing such things.

abhay-raizada commented 7 years ago

i will review in detail a little later but from just looking at it. It seems good. Can you please fix the commit message though? just do git commit --amend

abhay-raizada commented 7 years ago

this is a very good tutorial which helped me out a lot: https://www.atlassian.com/git/tutorials/rewriting-history/

hackrush01 commented 7 years ago

I'll change the commit message. But still this rebasing thing seems complex.

abhay-raizada commented 7 years ago

@hackrush01 i can't merged until your branch is rebased :(. These kind of things crop up very frequently sooner or later you'll have to learn