search

NITDgpOS / UIP

A library, to customize your desktop wallpapers.
https://nitdgpos.github.io/projects/UIP
GNU Affero General Public License v3.0
19 stars 45 forks source link

Gallery: Add Blur Feature #291

Closed abhay-raizada closed 7 years ago

abhay-raizada commented 7 years ago

Fixes https://github.com/NIT-dgp/UIP/issues/147

abhay-raizada commented 7 years ago

Hi thank you for your Patch make sure you have the right commit structure that is 

tag: Shortlog

body
Fixes <issue number/url>
abhay-raizada commented 7 years ago

image

Aniq55 commented 7 years ago

Please merge this after my PR is merged. XP (request)

abhay-raizada commented 7 years ago

Nope setwallpaper just calls this function

On 28-Dec-2016 3:31 PM, "Naveen Kumar Sangi" notifications@github.com wrote:

@nkprince007 commented on this pull request.

In uiplib/uipImage.py https://github.com/NIT-dgp/UIP/pull/291#pullrequestreview-14544419:

+

  • def resize(self, dimensions):
  • """Resize the image using ANTIALIAS resampling."""
  • self.dimensions = dimensions
  • resample = Image.ANTIALIAS
  • return self.image.resize(dimensions, resample=resample)
  • def save(self):
  • """Save the image while applying all the parameters used to edit it."""
  • if self.edited:
  • filename, ext = os.path.splitext(self.original_path)
  • self.image_path = os.path.join(filename + '_uip' + ext)
  • if self._blur:
  • self.image = self.image.filter(ImageFilter.GaussianBlur(
  • radius=float(self._blur_radius)))
  • self.image.save(self.image_path)

Could we remove this too? Since we're saving the image in set_wallpaper method?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NIT-dgp/UIP/pull/291#pullrequestreview-14544419, or mute the thread https://github.com/notifications/unsubscribe-auth/AIIwPz-mfe_84j0PQeEjabdzdd3WnRNyks5rMjNggaJpZM4LWywB .

nkprince007 commented 7 years ago

This looks good, but would've been better if we inherited the Image class with UipImage