search

NITDgpOS / UIP

A library, to customize your desktop wallpapers.
https://nitdgpos.github.io/projects/UIP
GNU Affero General Public License v3.0
19 stars 45 forks source link

moves exit_UIP() from UIP.py to utils/utils.py #342

Closed SACHIN-13 closed 7 years ago

SACHIN-13 commented 7 years ago

fixes: #340

abhay-raizada commented 7 years ago

Hi thank you for your Patch make sure you have the right commit structure that is 

tag: Shortlog

body
Fixes <issue number/url>

Also please upload a screenshot if you have made changes to the gui.

nkprince007 commented 7 years ago

SIGSTOP could be used in conjunction, right?

abhay-raizada commented 7 years ago

Both work

On 25-Jan-2017 10:06 PM, "Naveen Kumar Sangi" notifications@github.com wrote:

SIGSTOP could be used in conjunction, right?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NIT-dgp/UIP/pull/342#issuecomment-275158611, or mute the thread https://github.com/notifications/unsubscribe-auth/AIIwPzEBWLlCSSuAGAgyzP4MJXXfc_TXks5rV3nzgaJpZM4LtTer .

nkprince007 commented 7 years ago

I mean like, we could use SIGSTOP and resume later, right? Rather than killing it, IMO.

abhay-raizada commented 7 years ago

But why would we want that? There's a reason this function is exit_uip right?

On 25-Jan-2017 10:07 PM, "Naveen Kumar Sangi" notifications@github.com wrote:

I mean like, we could use SIGSTOP and resume later, right?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/NIT-dgp/UIP/pull/342#issuecomment-275159057, or mute the thread https://github.com/notifications/unsubscribe-auth/AIIwP0PHZISzKK-BtCO8DVTVEgxW4VbCks5rV3pHgaJpZM4LtTer .

nkprince007 commented 7 years ago

@SACHIN-13 Please amend your commit according to contribution guidelines. Please add the issue reference https://github.com/NIT-dgp/Guidelines/blob/master/CONTRIBUTING.md