search

NITDgpOS / UIP

A library, to customize your desktop wallpapers.
https://nitdgpos.github.io/projects/UIP
GNU Affero General Public License v3.0
19 stars 45 forks source link

Auto-delete old wallpapers after x days. #347

Closed SACHIN-13 closed 7 years ago

SACHIN-13 commented 7 years ago

a column is added to accept the no. of days after which the user wants the wallpapers to be deleted automatically. A utility function auto_flush to perform the same and a test to the mentioned function! Fixes #316 ![Uploading Screenshot from 2017-01-29 13-00-40.png…]()

abhay-raizada commented 7 years ago

Hi thank you for your Patch make sure you have the right commit structure that is 

tag: Shortlog

body
Fixes <issue number/url>

Also please upload a screenshot if you have made changes to the gui.

nkprince007 commented 7 years ago

Maybe a commit message like 

GUI: Add a column to set auto flush timeout

would be welcome to the first commit. Change it to something else, if you find any better words. Amend both the commits, and the final commit that fixes an issue, should have an issue reference ticker present in it. If in doubt, follow the Guidelines

SACHIN-13 commented 7 years ago

braces in line 77 instead of 78, ryt?

nkprince007 commented 7 years ago

Nope, just reduce one tab, that's enough.

Actually, either of them would do.

SACHIN-13 commented 7 years ago

shouldn't we create the file before its path is assigned to a variable?

nkprince007 commented 7 years ago

What's wrong with having known a file path where you're gonna create the file anyway? The point of using variables is to reuse them.. :P

nkprince007 commented 7 years ago

None of the commits in the PR have an issue reference. Please amend the commits to have one.

SACHIN-13 commented 7 years ago

made the changes and the commit amendments!

abhay-raizada commented 7 years ago

@nkprince007 merge! :D