scheduler: Correct schedule Thread use

NITDgpOS / UIP

A library, to customize your desktop wallpapers.

https://nitdgpos.github.io/projects/UIP

GNU Affero General Public License v3.0

19 stars 45 forks source link

scheduler: Correct schedule Thread use #352

Closed abhay-raizada closed 7 years ago

abhay-raizada commented 7 years ago

Fixes https://github.com/NIT-dgp/UIP/issues/351 CC @SACHIN-13 @nkprince007

abhay-raizada commented 7 years ago

Hi thank you for your Patch make sure you have the right commit structure that is

tag: Shortlog

body
Fixes <issue number/url>

Also please upload a screenshot if you have made changes to the gui.

SACHIN-13 commented 7 years ago

the code exits if UIP command is run, without any images being downloaded! probably because both the threads here are daemon threads so the main thread doesn't wait for them to finish and it itself stops. if we add an infinite loop after creating the scheduler thread in UIP.py, it solves the problem!

abhay-raizada commented 7 years ago

ahh yes, i see.

abhay-raizada commented 7 years ago

i'll try and make it work for both

nemani commented 7 years ago

Looks good. :+1: