search

NITDgpOS / UIP

A library, to customize your desktop wallpapers.
https://nitdgpos.github.io/projects/UIP
GNU Affero General Public License v3.0
19 stars 45 forks source link

Name of the class scheduler changed to Scheduler #363

Closed vartika-arora closed 7 years ago

vartika-arora commented 7 years ago

Name of the class scheduler changed to Scheduler: scheduler.py,mainGui.py,UIP.py

class 'scheduler' changed to 'Scheduler' in all classes of UIP Fixes #268

abhay-raizada commented 7 years ago

Hi thank you for your Patch make sure you have the right commit structure that is 

tag: Shortlog

body
Fixes <issue number/url>

Also please upload a screenshot if you have made changes to the gui.

nkprince007 commented 7 years ago

@vartika-arora please follow the correct commit structure.

abhay-raizada commented 7 years ago

@vartika-arora that's a nice commit, u just need to mae one change and follow the proper commit message structure

vartika-arora commented 7 years ago

I have made changes to mainGui.py. Are there still errors in my commit message?

abhay-raizada commented 7 years ago

@vartika-arora yes you need two squash your two commits together. and just have 1 commit which says something like : Rename scheduler to Scheduler and also add a fixes tag with issue no. See CONTRIBUTING.md for more on what is a proper commit structure

abhay-raizada commented 7 years ago

Awesome work @vartika-arora :D

abhay-raizada commented 7 years ago

merging :)

abhay-raizada commented 7 years ago

@vartika-arora i just noticed, the fixes tag was stilll missing

abhay-raizada commented 7 years ago

it's alright for now. i'll close the issue manually, althugh do keep this in mind from next time :)

vartika-arora commented 7 years ago

Thank you for merging! And I'll keep that in mind from next time