Add Coala for PEP8 - Githubissues

NITDgpOS / festcms

Fest management system using Django

21 stars 30 forks source link

Closed ghoshbishakh closed 7 years ago

ghoshbishakh commented 7 years ago

@nkprince007 take a look if all configs are OK

nkprince007 commented 7 years ago

And please try to add appveyor too, we might need to test on windows too, although this is only server stuff and is mostly run on linux only.

Mind the mac specific build for travis too.

nkprince007 commented 7 years ago

If you want me to work on this, I'll could fix this up for you. 😄

ghoshbishakh commented 7 years ago

@nkprince007 no I want you to review my work on this one 😉

nkprince007 commented 7 years ago

BTW please unhook the travis build until this work is complete, so that other PR's could remain unaffected.

ghoshbishakh commented 7 years ago

@nkprince007 let it be. We will just ignore travis.

nkprince007 commented 7 years ago

But why?

ghoshbishakh commented 7 years ago

@nkprince007 what why?

ghoshbishakh commented 7 years ago

@nkprince007 were you working on it?

nkprince007 commented 7 years ago

Closed 😝

nkprince007 commented 7 years ago

Nope.

ghoshbishakh commented 7 years ago

@nkprince007 nah just resetted it. Will repoen in a bit

nkprince007 commented 7 years ago

Ok.

ghoshbishakh commented 7 years ago

@nkprince007 review plase 😄

ghoshbishakh commented 7 years ago

@nkprince007 can we merge this fast so that we can check code standards for @akshatnitd ?

nkprince007 commented 7 years ago

I'll modify this PR and merge it once the tests go green, hope you don't mind.

ghoshbishakh commented 7 years ago

@nkprince007 how can tests go green?

nkprince007 commented 7 years ago

By adding another commit that fixes the errors shown. 😉

ghoshbishakh commented 7 years ago

@nkprince007 we will need to fix all pep8 and all stuff to make it green. That will be an ongoing process