NITDgpOS / manga

Manga downloader
34 stars 36 forks source link

needs support for macOS #34

Open nkprince007 opened 7 years ago

nkprince007 commented 7 years ago

Log message:

bash downloader.sh 
Enter Manga name:
one piece
downloader.sh: line 3: ${manga,,}: bad substitution
Enter the chapter range.
Start:
1
End:
1
Downloading page 1 of chapter 1.....
downloader.sh: line 46: $((length-1)): substring expression < 0

Check the expression cited above and fix it.

abhay-raizada commented 7 years ago

hey do you think this would help? https://github.com/NIT-dgp/manga/issues/23 once this is fixed mac would automatically get supported right? though i guess keep this issue open so we are reminded to test :D

nkprince007 commented 7 years ago

Yeah, the python script should definitely fix that.