Closed nkprince007 closed 7 years ago
Looks Great :+1:
It would be nice if /projects/UIP
was navigable from the main site. Perhaps you can add a projects subheading in the home page. Also, please mention credits if you have used code from someone, otherwise its cool :100: .
@sonalkr132, if you're asking about MaterializeCSS and jQuery credits, yeah sure. Rest of the stuff is </> by me.
And about the main site linking, I'll be soon updating the home page of the site with a new design and a projects index page too, to show a list of projects and change the default header.
Project with logo:
Project without logo(Auto adjustments):
For wallpapers, is more like it lets you download, change and everything else with wallpapers.
On Wed, 15 Feb 2017 at 09:45, Abhay Raizada notifications@github.com wrote:
@abhsag24 commented on this pull request.
In projects/UIP.md https://github.com/NIT-dgp/nit-dgp.github.io/pull/14:
@@ -0,0 +1,69 @@ +--- +layout: project +title: UIP +permalink: projects/UIP +description: A cross-platfrom desktop application for wallpapers.
but i dont get what for wallpapers means? rather make it, A cross-platform application for your desktop ?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/NIT-dgp/nit-dgp.github.io/pull/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AQZ-ypEQv9f67cRPt9J_xUT5okQ5T7Fnks5rcnvygaJpZM4L-XiA .
-- Sent from Gmail via iPhone
@nkprince007 is there more work to be done in this PR?
I don't think so @sonalkr132
The front matter page.title gives the URL for API stuff. And that can't be passed into a script sourced from somewhere else.
I think it is important that js is shareable. Most likely rest of projects will use same project template.
Can't window.location
be used for preparing the url for api calls? Alternatively, you can also add a meta tag for url and read it with jquery $('meta[name=github_url]').attr("content");
.
Yeah, meta tag looks convincing @sonalkr132. :smile:
Thanks @nkprince007 This looks mergable. :+1: