NITDgpOS / nitdgpos.github.io

NIT Durgapur Open Source Community Website
https://nitdgpos.github.io/
GNU General Public License v3.0
12 stars 16 forks source link

Add basic project view and UIP gh-pages site. #14

Closed nkprince007 closed 7 years ago

nkprince007 commented 7 years ago

screen shot 2017-02-12 at 7 47 10 am screen shot 2017-02-12 at 7 47 20 am screen shot 2017-02-12 at 7 47 26 am screen shot 2017-02-12 at 7 47 32 am screen shot 2017-02-12 at 7 47 37 am

sonalkr132 commented 7 years ago

Looks Great :+1: It would be nice if /projects/UIP was navigable from the main site. Perhaps you can add a projects subheading in the home page. Also, please mention credits if you have used code from someone, otherwise its cool :100: .

nkprince007 commented 7 years ago

@sonalkr132, if you're asking about MaterializeCSS and jQuery credits, yeah sure. Rest of the stuff is </> by me.

nkprince007 commented 7 years ago

And about the main site linking, I'll be soon updating the home page of the site with a new design and a projects index page too, to show a list of projects and change the default header.

nkprince007 commented 7 years ago

Project with logo: screen shot 2017-02-14 at 4 47 02 am

Project without logo(Auto adjustments): screen shot 2017-02-14 at 4 47 25 am

nkprince007 commented 7 years ago

For wallpapers, is more like it lets you download, change and everything else with wallpapers.

On Wed, 15 Feb 2017 at 09:45, Abhay Raizada notifications@github.com wrote:

@abhsag24 commented on this pull request.

In projects/UIP.md https://github.com/NIT-dgp/nit-dgp.github.io/pull/14:

@@ -0,0 +1,69 @@ +--- +layout: project +title: UIP +permalink: projects/UIP +description: A cross-platfrom desktop application for wallpapers.

but i dont get what for wallpapers means? rather make it, A cross-platform application for your desktop ?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/NIT-dgp/nit-dgp.github.io/pull/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AQZ-ypEQv9f67cRPt9J_xUT5okQ5T7Fnks5rcnvygaJpZM4L-XiA .

-- Sent from Gmail via iPhone

sonalkr132 commented 7 years ago

@nkprince007 is there more work to be done in this PR?

nkprince007 commented 7 years ago

I don't think so @sonalkr132

sonalkr132 commented 7 years ago

The front matter page.title gives the URL for API stuff. And that can't be passed into a script sourced from somewhere else.

I think it is important that js is shareable. Most likely rest of projects will use same project template. Can't window.location be used for preparing the url for api calls? Alternatively, you can also add a meta tag for url and read it with jquery $('meta[name=github_url]').attr("content");.

nkprince007 commented 7 years ago

Yeah, meta tag looks convincing @sonalkr132. :smile:

sonalkr132 commented 7 years ago

Thanks @nkprince007 This looks mergable. :+1: