add binary search in c

[varunkmr19]

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Fixes #44

By submitting this pull request I confirm I've read and complied with the below declarations.

• [x] I have read the Contribution guidelines and I am confident that my PR reflects them.
• [x] I have followed the commit guidelines for this project.
• [x] My code follows the standard code structure.
• [x] This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
• [x] This pull request will be closed if I fail to update it even once in a continuous-time span of 7 days.
• [x] This pull request shall only be reviewed and merged once all the checks pass. No maintainer or supporter shall be obliged to review it before this condition is met.
• [x] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

[varunkmr19]

I went through the logs of Travis CI. It says there are some extra whitespaces in my source code. So, should I fix it or is it good enough for a merge?

[sangamcse]

Yes @varunkmr19, the fix is needed. Also, it would be great if you go through https://github.com/NITSkmOS/Algorithms/blob/master/CONTRIBUTING.md#write-good-commit-messages and do the necessary changes. Also, can you add entry in README.md?

[sameerchoubey]

@varunkmr19 There are few things that need to be sorted for this PR to get merged.

a) At line 5, we cannot obtain the size of an array after passing it inside a function because only the first address of the array is passed inside the function. When we pass an array to a function, it decays into a pointer to the first element, at which point knowledge of its size is not known. So, it would be something like this, after the change, int main(){ int end = sizeof(arr)/sizeof(arr[0]); int ans = binary_search(arr, end, target); }

b) Also, update the README file and remove the extra spacing.

Everything else looks good.

[varunkmr19]

Don't know why It's not passing all the checks. Even after I fixed the code and removed the extra spacing as well.

[varunkmr19]

Finally, I found out what the issue was. I had installed prettier(a VScode extension) which was messing with the alignment.

[sameerchoubey]

That's great. But, please squash your commits.

[sangamcse]

@varunkmr19 can you please go through the review comments and do the changes that are requested?