NIVANorge / icp_waters_qc_app

Basic quality checking of data templates submitted to the ICP Waters database
0 stars 0 forks source link

Improve documentation for ion balance and theoretical conductivity calculations #1

Open JamesSample opened 2 years ago

JamesSample commented 2 years ago

I've added calculations for the ion balance and theoretical conductivity based on functions previously written for the Aquamonitor QC app. Where two versions of the calculations are available, I've used Øyvind G's method rather than the one already implemented in RESA.

It would be nice to improve the documentation for these functions so that this code is easier to maintain. @kariaust @catbgun can you help to answer any of the following questions, please?

It would be great if you could find time to test the new functions by e.g. uploading data with known good and bad ion balances and theoretical conductivity.

Thank you! :-)

catbgun commented 2 years ago

Here follows answers to the questions, with inputs from Øyvind Garmo, Rolf D. Vogt and @kariaust

Hope this was useful. Let me know when the functions have been updated (setting parameters to zero when data is not provided) and I will upload a test-datafile.

JamesSample commented 2 years ago

Thanks @catbgun!

I've added some details to the documentation and made NH4, LAl and A- optional. Please give it a go and let me know how you get on :-)

Thanks!