NIVeriStandAdd-Ons / UDP-Data-Link-Custom-Device

6 stars 14 forks source link

Depends on version 0.1.0 of the VeriStand Data Library #21

Open christinesparks opened 6 years ago

christinesparks commented 6 years ago

There were breaking changes between version 0.1.0 and 0.2.0 of the VeriStand Data Library that improved performance. The source should be updated to use the most recent VIs.

songlijie commented 6 years ago

Thank you very much. There still an other issue, I rebuild this custom device in Labview 2017 and added it to VeriStand 2017 ,The Rx Packets can add normally ,But Tx Packets can not add channels. when add channel in Rx Packets,the file "channel configuration"and the floder "channels" created,But in Tx Packets, only the file"channel configuration" be created,the floder"channels"not be created.

rdp137 commented 5 years ago

Does this mean I need to install Veristand Data Library 0.1.0 instead of the latest version? if so how do I find it?

songlijie commented 5 years ago

You can find it at https://github.com/NIVeriStandAdd-Ons/VeriStand-Data-Library

ryanvallieres commented 5 years ago

Figured I pop in here talk to this.

I'm hoping to get this all bumped up to the latest version of the VS Data toolkit in the near future. Probably release 1.4.X or something. There a few other issues driving development, but the general improvements of the 0.2.0 version are attractive for the improved run-time performance.

rdp137 commented 4 years ago

did a version of this custom device that uses the new version of the VS Data toolkit ever get released? or should I still be using the older version?

ryanvallieres commented 4 years ago

@rdp137 This still depends on version 0.1.0, I believe. It's always been on my list to do, but other features ended up taking priority. I plan on getting to it eventually, but it's definitely not going to be until after the turn of the new year.

I'd suggest seeing this old issue for the specific compatible version: https://github.com/NIVeriStandAdd-Ons/UDP-Data-Link-Custom-Device/issues/49

ryanvallieres commented 4 years ago

Update on this issue!

The UDP Custom Device encounters issues when deploying to the same system as a CD using the 0.2 version of the Veristand Data toolkit. In a nutshell, if another CD is loaded onto a system with the 0.2 VS Data, the UDP CD will no be able to execute due to a conflict in namespacing and versioning. This is inherently due to differences in the public interfaces of the 0.1.X.Y and the 0.2.A.B versions of the VS Data and how custom devices are packaged into LLBs.

Because this issue is now causing significant problems with other CDs in the Veristand ecosystem, I will be attempting to update the UDP Custom Device to 0.2.1.5 over the next few days. This should be a fairly painless conversion, but I will test the CD extensively to try to make sure this change does not break any of the core functions of the UDP CD.

With some luck, I'll have a PR ready some time next week (or earlier) with the 0.2.1.5 VS Data dependency.

ryanvallieres commented 4 years ago

Just to come full circle on this, the custom device is now fully dependent on the VS Data toolkit version 0.2.1.5.

Best I can tell, it's been a non-destructive update and everything appears stable. I'll be keeping my eyes peeled for anything strange though.

The first version to support this update is version 1.4.0,