NIVeriStandAdd-Ons / Waveform-Processing-Custom-Device

Other
1 stars 13 forks source link

Processing waveforms not from DAQ #10

Open rdecarreau opened 5 years ago

rdecarreau commented 5 years ago

I don't have background as to why the waveform processor was limited to just waves from DAQ, but I would like to process waveforms from the FPGA Addon. Is it feasible to add that ability? p.s. I will be making a variation of this CD which can process waveforms from FPGA. I would like to just include it in this CD if possible.

keprt commented 5 years ago

If I remember, there is a possibility (or at least it was planned) to produce waveform from custom devices. Check the VS waveform palette in LV

rdecarreau commented 5 years ago

The FPGA Add-on produces waveforms already, it's just a matter of piping those waveforms into the Processing Plugin. The Waveform Logging CD has a really nice browser UX that I think we can re-use. I just don't know if there is a reason that we restricted this Waveform Processing CD to just DAQ in the first place.

rdecarreau commented 5 years ago

I am going to try and stuff the Waveform Logging UX on top of the Waveform Processing CD. If that works, that would be sweet.

adchurch commented 5 years ago

@rdecarreau as I recall we limited the plugin to using DAQ waveforms to simplify the design. I think it was easy to get DAQ waveforms because the DAQ section GUID is always the same? Whereas to pull waveforms from other custom devices requires a little more thought. It's been a long time since I looked at the code but probably no reason the design can't be modified to process waveforms from the FPGA Add-on.

Good luck!

rdecarreau commented 5 years ago

Thanks! I am thinking this implementation would be similar to the waveform logging custom device's waveform selector. Then the Task Rate would be manually entered.