search

NJACKWinterOfCode / JS-OS

An Unified Operating System on the web
3 stars 3 forks source link

Fix file manager #1

Open RAJAGOPALAN-GANGADHARAN opened 4 years ago

RAJAGOPALAN-GANGADHARAN commented 4 years ago

File Manager works locally but doesn't work gh-pages.

dev-sankhadip commented 4 years ago

Can you please explain the issue? by the way this project is amazing.

RAJAGOPALAN-GANGADHARAN commented 4 years ago

Great thanks. When you try to run it locally under npm File explorer app works. But apparently when I pushed it to gh-pages, the demo link u can find it in readme doesnt work. So I need you to inspect it. Maybe look into console logs to find something suspicious. Investigate what is going wrong. Ping me if you have any more queries.

dev-sankhadip commented 4 years ago

Ok i checked it in readme. File explorer is not opening. So i need to correct it, right? One more query what is gh-pages?

RAJAGOPALAN-GANGADHARAN commented 4 years ago

The os is deplaoyed on the web using gh-pages(similiar to heroku etc).Also few changes were made to the master branch. Apply those changes to gh-pages as well please.

dev-sankhadip commented 4 years ago

Ok got it

ankushbhardwxj commented 4 years ago

@RAJAGOPALAN-GANGADHARAN leader board wasn't updated for last 2 PRs. Did you add points ? Also, are you on any other social media so that I can contact you if I need.

RAJAGOPALAN-GANGADHARAN commented 4 years ago

Added please check now. You can find me on IRC (Rajagopalan you can find my handle in #qtwebkit channel too), Linked in https://www.linkedin.com/in/rajagopalan-gangadharan

ankushbhardwxj commented 4 years ago

@RAJAGOPALAN-GANGADHARAN Oh, I see you did GSOC at Haiku. That's great. I'm also gonna apply to GSoC 2020. NWoC was just my way of validating myself coz I thought I wasnt good enough 😆

RAJAGOPALAN-GANGADHARAN commented 4 years ago

You are way awesome try I'm sure you will get GSOC 20

ankushbhardwxj commented 4 years ago

Thanks man. I'll try my best 💯