search

NJACKWinterOfCode / JS-OS

An Unified Operating System on the web
3 stars 3 forks source link

Calculator App #23

Closed ankushbhardwxj closed 4 years ago

ankushbhardwxj commented 4 years ago

An OS is always incomplete without a Calculator app. Let's create a calculator app for JS-OS

ankushbhardwxj commented 4 years ago

@RAJAGOPALAN-GANGADHARAN I'll get this done 👍

RAJAGOPALAN-GANGADHARAN commented 4 years ago

Ofcourse Cool one. Also I am going to update the editor. It seems i havent used monaco. Hang on

ankushbhardwxj commented 4 years ago

Cool! I have some ideas too for the editor. Will work on it soon 💯

RAJAGOPALAN-GANGADHARAN commented 4 years ago

Could you rebase changes before commiting, cause I have updated the editor.

ankushbhardwxj commented 4 years ago

you updated editor on this branch(NJACK one) ??

RAJAGOPALAN-GANGADHARAN commented 4 years ago

well in the parent one set ur upstream to my repo RAJAGOPALAN-GANGADHARAN/JS-OS and fetch and rebase

RAJAGOPALAN-GANGADHARAN commented 4 years ago

Did few more changes please rebase now

RAJAGOPALAN-GANGADHARAN commented 4 years ago

Also FileSystem is more prioritized could you try fixing it thanks.

ankushbhardwxj commented 4 years ago

I dont know why but the monaco code update has broken the code, Capture @RAJAGOPALAN-GANGADHARAN please look into this issue

ankushbhardwxj commented 4 years ago

BTW, the calculator is ready. Let me know when you fix this so that I can make a PR.

RAJAGOPALAN-GANGADHARAN commented 4 years ago

Delete the package-lock and try doing npm install again.

On Fri, Dec 20, 2019 at 9:49 PM Ankush Bhardwaj notifications@github.com wrote:

BTW, the calculator is ready. Let me know when you fix this so that I can make a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NJACKWinterOfCode/JS-OS/issues/23?email_source=notifications&email_token=AG7RD7NZN3ZANUX722MZI5DQZTV7RA5CNFSM4J563SUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHNLJGI#issuecomment-567981209, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7RD7JM46E46RL6LHWMPSLQZTV7RANCNFSM4J563SUA .

ankushbhardwxj commented 4 years ago

did it , got the same problem

RAJAGOPALAN-GANGADHARAN commented 4 years ago

Works fine on windows are you using WSL? try on windows maybe

ankushbhardwxj commented 4 years ago

I'm on WSL

RAJAGOPALAN-GANGADHARAN commented 4 years ago

Yes npm for WSL is pain. Try using bare windows it should work fine.

ankushbhardwxj commented 4 years ago

I swear windows is crazy. I just restarted the computer and ran npm install and it ran perfectly. However on npm start it gives error.

ankushbhardwxj commented 4 years ago

I think you missed to add a dependency monaco-editor-webpack-plugin. As soon as I installed that , everything worked. 👍