search

NJACKWinterOfCode / NJACKWinterOfCode.github.io

Website for NJACK Winter of Code 2020
https://njackwinterofcode.github.io
MIT License
21 stars 29 forks source link

Stats Icons in register page are less semantic #74

Closed s-ayush2903 closed 3 years ago

s-ayush2903 commented 3 years ago

Describe the problem Icons present in the register page of the website are very less semantic when it comes to the text written below them.

Proposed fix/solution Those icons need to be changed in accordance to the entity mentioned there.

Screenshots/Visuals icons

yash0501 commented 3 years ago

@s-ayush2903 I would like to work on this issue. Please assign it to me.

yash0501 commented 3 years ago

Is this ok? If yes, I will make a PR for it. pr

s-ayush2903 commented 3 years ago

@yash0501 It'll be better if for projects we use the icon that github uses for repositories, like the one which you can see adjacent to a repository's name, this'll be nice. And I believe the icon for participants too can be changed. You may look for icons on undraw.co, it is a nice place for tasks like this.

yash0501 commented 3 years ago

new Is it OK now?

s-ayush2903 commented 3 years ago

We don't need three dots/mini-squares on the projects icon, and for participants icon, we can revert back to the very first version that you suggested, after these changes, it'll be fine.

s-ayush2903 commented 3 years ago

Closing in favor of #80