Remove alpha channel for apple-touch-icon

NJAldwin / eleventy-plugin-gen-favicons

Favicon generator plugin for eleventy

MIT License

15 stars 4 forks source link

Remove alpha channel for apple-touch-icon #11

Open nielsbom opened 9 months ago

nielsbom commented 9 months ago

I'm not entirely sure of the ramifications of this. I also didn't add any tests because I didn't see any asserts on image alpha channels/transparency.

The goal of the change is to have apple-touch-icon get the given background color, even if the source image has transparent parts.

Let's discuss if you want to :-)

NJAldwin commented 5 months ago

I'm open to this, but I wonder whether it should be an option? Can you tell me more about your use case?

If we can make it an option and add tests, I am happy to merge.