Closed elvece closed 1 month ago
Hi @elvece it has been over a year -- if you have any notes in reply to my comment above I am happy to take another look.
Hi @elvece it has been over a year -- if you have any notes in reply to my comment above I am happy to take another look.
Hi there, apologies, I spaced on this. Let me revisit this week and address your comment.
@NJAldwin I'm having trouble re-creating this on my machine (macOS 14.5), but the issue a previous co-worker on Linux (don't have system details) had was that the favicon files (specifically the apple-touch-icon.png, icon-192.png, and icon-512.png) were being regenerated every time the project was built, causing a git difference (example). IIRC the change I made fixed this for him, but I see now that it's probably not the right solution. Since I cannot re-create, I will close this PR and re-open with the appropriate details should it occur again.
Hi, thank you for your PR! Can you please elaborate on the issue you were having, explain your change, and provide a test case showing this fixes it? I am happy to look into the issue further.
Right now, this change appears to fail all the caching tests and several others (after I fix the failing lint due to the trailing semicolon):