search

NJU-3DV / Relightable3DGaussian

[ECCV2024] Relightable 3D Gaussian: Real-time Point Cloud Relighting with BRDF Decomposition and Ray Tracing
https://nju-3dv.github.io/projects/Relightable3DGaussian/
Other
458 stars 34 forks source link

About the intrinsic center is not at the image center. #13

Open DavidXu-JJ opened 8 months ago

DavidXu-JJ commented 8 months ago

Hi everyone.

Thank you for sharing your nice work with the community. I also benefit a lot from your work.

I have some problems with the situation where the cx and cy of the intrinsic matrix are not at the image center.

I see your code at https://github.com/NJU-3DV/Relightable3DGaussian/blob/77827626db514d59b390da2474de5d71be61a2e6/scene/cameras.py#L69C38-L69C68 to handle this problem.

I also noticed that you passed the cx and cy to the rasterizer render part. I wonder whether you treat the above mentioned case specially in CUDA part code. I haven't seen special treatment during my first rough reading.

Did I miss something important about this weird camera case?

Many thanks in advance!