NKI-AI / ahcore-old

Ahcore are the AI for Oncology histopathology core models
Apache License 2.0
0 stars 1 forks source link

Fixes/inference tissue subtypes #3

Closed AjeyPaiK closed 1 year ago

AjeyPaiK commented 1 year ago

This PR:

  1. Fixes{#1, #2}
  2. Adds default data description configs for tissue subtype segmentation.
  3. Adds a flag that allows logging epoch level loss while training.
  4. Adds default configs for inference trackers.
jonasteuwen commented 1 year ago

Early comments:

AjeyPaiK commented 1 year ago
  1. I have removed the configs we use for our internal experiments.
  2. Some files seem edited even though nothing happened due to Black. Now, this repo passes black.
  3. We have both epoch level loss and also batch level loss being logged. Although, the batch level loss will be logged once every 50 steps (which is the pytorch lightning default).
  4. Yes, better solutions are possible rather than setting mask to None during inference. Perhaps a separate manifest for inference? Added it as a fixme.
jonasteuwen commented 1 year ago

I agree with the changes for now