search

NKI-AI / ahcore

Ahcore is the AI for Oncology core computational pathology toolkit
Apache License 2.0
15 stars 1 forks source link

Scaling of geojson annotations not supported while dataloading. #13

Closed AjeyPaiK closed 9 months ago

AjeyPaiK commented 10 months ago

Currently, during the dataloading phase, ahcore loads annotations from the manifest and relies on dlup to do so.

Normally, to scale my geojson annotations, I'd call the from_geojson(path, scaling) method of the WsiAnnotations class which can be found here.

As of yet in ahcore, there isn't an option to pass the scaling parameter to the annotation reader. It can be found here.

This is a problem since it's important to scale the annotations appropriately while dataloading.

AjeyPaiK commented 10 months ago

@jonasteuwen let me know what to do here. Since ahcore is designed with the assumption that the annotations it gets are always at level 0, the issue I raised now seems moot. If we want to address it, we should discuss this at some point. If not, I will close this issue.