search

NKI-AI / ahcore

Ahcore is the AI for Oncology core computational pathology toolkit
Apache License 2.0
15 stars 1 forks source link

Fix H5FileImageWriter Callback #17

Closed AjeyPaiK closed 8 months ago

AjeyPaiK commented 10 months ago

Fixes {#16}

  1. After #16 was reported, upstream dlup was modified to return the scaled bounds. While writing H5 files, we now directly call this function to infer the scaled size of the WSI.
AjeyPaiK commented 9 months ago

@jonasteuwen Can you please review this PR? It's been here for some time.

jonasteuwen commented 9 months ago

@AjeyPaiK I think current dlup version should make this very easy on you. You can use .get_scaled_bounds for offset and size. Then you should probably also check if a new region_index happens in the sample index, because that won't be supported.

AjeyPaiK commented 9 months ago

@jonasteuwen Now, I think this is good to go!

AjeyPaiK commented 8 months ago

Issue addressed in #22