NKI-AI / ahcore

Ahcore is the AI for Oncology core computational pathology toolkit
Apache License 2.0
15 stars 1 forks source link

CCITTFAX4 compression is not supported by tiffile in upstream dlup. #48

Closed AjeyPaiK closed 7 months ago

AjeyPaiK commented 8 months ago

Describe the bug Writing tiff files using the tiff_callback breaks when we use CCITTFAX4 compression. I get the following error:

image

To Reproduce Write any tiff image using the tiff callback.

Expected behavior N/A

Environment dlup version: 0.3.35 How installed: Installed using pip as an editable package Python version: 3.9.5 Operating System: linux

Additional context N/A

moerlemans commented 8 months ago

This is fixed by changing https://github.com/NKI-AI/ahcore/blob/960f25aa533d0f3b2386b27e00e025d938c3ef8f/ahcore/callbacks/tiff_callback.py#L203 to ZSTD