search

NKI-AI / ahcore

Ahcore is the AI for Oncology core computational pathology toolkit
Apache License 2.0
15 stars 1 forks source link

AhcoreJitModel extended for specific inference cases. #84

Closed AjeyPaiK closed 2 months ago

AjeyPaiK commented 3 months ago

Fixes #81

  1. AhcoreJitModel is renamed to BaseAhcoreJitModel
  2. BaseAhcoreJitModel can now be inherited based on the type of the JIT model being used.
  3. A class DinoV2JitModel is inherited from BaseAhcoreJitModel which can be used for feature extraction (based on large models like Dinov2.)
  4. A class SegmentationJitModel is inherited from BaseAhcoreJitModel that can be used for segmentation inference.
  5. In ahcore.utils.types, several custom types are defined so that ahcore can easily be extended to any type of JIT compiled models.
AjeyPaiK commented 3 months ago

Hi @EricMarcus-ai, thanks for the great comments and suggestions to improve. Your reference codebase really helped me.

Two things after my latest push, The comments to which I haven't replied are no longer applicable because the code is changed. The ones that I've replied to have been addressed.

Another round of review should set this right.