Code Quality - Githubissues

NKI-AI / direct

Deep learning framework for MRI reconstruction

https://docs.aiforoncology.nl/direct

Apache License 2.0

236 stars 41 forks source link

Code Quality #193

Closed georgeyiasemis closed 2 years ago

georgeyiasemis commented 2 years ago

Is your feature request related to a problem? Please describe. Improve code quality.

Requirements

[x] Typing is not completed everywhere
- [ ] Inference on single volumes will currently work only on single GPUs
[ ] It is implicitly assume that volumes have a unique name, so it can't happen we have /kspace.h5. Add an identifier.
[x] Remove all non-ambiguous assert_complex tests
[x] Refactor self.cropper on the engines, this can be a separate function crop_volume.
[x] Increase test coverage

georgeyiasemis commented 2 years ago

[x] Remove all ambiguous assert_complex tests

Need to remove all assert_complex tests where there's unambiguity of where the complex axis should be. We can make it explicit, maybe by specifying complex_axis.