NKI-AI / direct

Deep learning framework for MRI reconstruction
https://docs.aiforoncology.nl/direct
Apache License 2.0
228 stars 40 forks source link

Add import in datasets_config.py #247

Closed zwep closed 1 year ago

zwep commented 1 year ago

Describe the bug

On the page https://docs.aiforoncology.nl/direct/datasets.html there is an example class called 'MyDatasetConfig'.

There the following is defined

lists: List[str] = field(default_factory=lambda: [])

I think it would help if an additional import statement is added:

from datasets import fields

since the original direct/data/datasets_config.py file does not contain it

To Reproduce Go to https://docs.aiforoncology.nl/direct/datasets.html Check the example datasetconfig implementation

Expected behavior I expected to not have errors when I paste this piece of code

Environment dlup version: Not installed. direct version: 1.0.5.dev0 How installed: using conda Python version: 3.9 Operating System: NAME="Debian GNU/Linux" VERSION_ID="11" VERSION="11 (bullseye)" VERSION_CODENAME=bullseye

Additional context Add any other context about the problem here. `