Fix annotation order of WsiAnnotations when sorting is None

NKI-AI / dlup

Dlup are the Deep Learning Utilities for Pathology developed at the Netherlands Cancer Institute

Apache License 2.0

25 stars 7 forks source link

Fix annotation order of WsiAnnotations when sorting is None #215

Closed BPdeRooij closed 10 months ago

BPdeRooij commented 10 months ago

This PR fixes #{214} by removing the sorting of available_labels.

jonasteuwen commented 10 months ago

@BPdeRooij Could you move this function to the respective functions that do use area sorting? That way the current behavior would not change. Also mypy seems to fail.

BPdeRooij commented 10 months ago

I believe I addressed your comment with this commit. Mypy was failing because of the new type hinting of OpenCV version 4.9.0. I ensured that current behavior does not change by sorting available_labels whenever AnnotationSorting is not None.