NKI-AI / xdrt

XDRT (XDR Toolkit) is a python toolkit to work with the Elekta XDR and XVI file formats.
https://docs.aiforoncology.nl/xdrt
Other
14 stars 4 forks source link

decompression library not compiled #6

Closed ydehond6 closed 3 years ago

ydehond6 commented 3 years ago

Describe the bug Used xdr2img to convert a .scan file to .nrrd file. Error message (decompression library not compiled) after changing in function xdr_reader.py r.21 to nki_compression = ctypes.cdll.LoadLibrary( str(Path(path.dirname(path.abspath(file))).parent / "lib" / nki_decompress_lib # type: ignore ))

Environment dlup version: How installed: pip install xdrt Python version: 3.8 Operating System: windows 10

jonasteuwen commented 3 years ago

Thanks. I have pushed an update to the windows_fix branch. I have installed both MSVC and CMake. Will double check later today if it runs on windows properly now (it does on OS X).

jonasteuwen commented 3 years ago

The version updated on PyPi should work now. I have used Cmake (https://cmake.org/download/) for windows and MSVC as compiler. If you do that pip install xdrt should work if cmake is in your path. Let me know if you can get it to work, I will write some documentation about it.

After I'll work on #7.

ydehond6 commented 3 years ago

Thank you for updating the code. However, I have problems with installing xdrt now.
subprocess.CalledProcessError: Command '['cmake', '--version']' returned non-zero exit status 1. I have b'cmake version 3.20.5\n\nCMake suite maintained and supported by Kitware (kitware.com/cmake).\n'

jonasteuwen commented 3 years ago

CMake does not appear to be in the path of your environment, the complaint is that it cannot run cmake —version

On 14 Jul 2021, at 09:08, ydehond6 @.***> wrote:

 Thank you for updating the code. However, I have problems with installing xdrt now. subprocess.CalledProcessError: Command '['cmake', '--version']' returned non-zero exit status 1. I have b'cmake version 3.20.5\n\nCMake suite maintained and supported by Kitware (kitware.com/cmake).\n'

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

ydehond6 commented 3 years ago

Thank you! it worked by using a new enviroment and not install cmake through pip before installation of xdrt.

jonasteuwen commented 3 years ago

Ah, that's great. Can you summarize your steps?

Now you should be able to do xdr2img <object with .scan or .xdr extension> output.nii.gz and open output.nii.gz in ITK-Snap or Slicer or so. I'll work on your other request as well.

ydehond6 commented 3 years ago

install cmake at https://cmake.org/download/ in anaconda powershell prompt :

conda create -n test python==3.8 conda activate test pip install xdrt

and : xdr3img input.scan output.nrrd worked

So I don't know why it first did not work but now it works