NKI-CCB / DISCOVER

DISCOVER co-occurrence and mutual exclusivity analysis for cancer genomics data
Apache License 2.0
27 stars 6 forks source link

correct warning caused by 'nan' in comparison #3

Closed solo7773 closed 6 years ago

solo7773 commented 6 years ago

Correct the following warning RuntimeWarning: invalid value encountered in less i, j = numpy.where(self.pi0 * numpy.asarray(self.qvalues) < q_threshold)

scanisius commented 6 years ago

Thank you for reporting this issue and the suggested fix. In the update to the DISCOVER package that I just pushed to GitHub I chose a different solution though. The reason for this being that I prefer to keep the nans, as I consider them to be the closest alternative to having an actual not-available value.

Anyway, the warnings should be gone now in the latest GitHub version. I will be uploading the new version to our conda repository soon.