Override method should be change

NKoonen / vatchecker

[Prestashop]Checks if customer has a valid VAT number, and then puts the customer a specific group.

https://customs-documents.com

BSD 3-Clause "New" or "Revised" License

34 stars 14 forks source link

Override method should be change #48

Open Triloworld opened 4 months ago

Triloworld commented 4 months ago

Hello, Module is great. We like to help support as we need update old module to this one. Right now your module is best candidate but there is used override pattern that isn't recommended

Recommended pattern to work with PayPal is from example module - https://github.com/202ecommerce/paypal/issues/150 Prestashop have hooks that is used to evaluated Tax.

There is need to have composer, hook and Github Action to generate zip package. This will help new adoption

NKoonen commented 4 months ago

Sounds good, you can make a pull request.

NKoonen commented 3 months ago

I think this issue is resolved with the latest version, right?