Added support for passing url params through data argument

DionAkkerman commented 1 year ago

url params can be passed a dictionary (or list of tuples) to the "param" argument for easier building of get/delete requests.
Simplified passing of json arguments to the body (requests "json" param is the same as dumping and then adding it to the "data" param)

codecov[bot] commented 1 year ago

Codecov Report

Merging #31 (cefc13c) into master (8abe054) will decrease coverage by 3.34%. Report is 33 commits behind head on master. The diff coverage is 15.73%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   48.13%   44.80%   -3.34%     
==========================================
  Files          18       21       +3     
  Lines         833      915      +82     
==========================================
+ Hits          401      410       +9     
- Misses        432      505      +73

Files	Coverage Δ
nldcsc/__init__.py	`100.00% <100.00%> (ø)`
nldcsc/generic/times.py	`0.00% <ø> (ø)`
nldcsc/loggers/app_logger.py	`100.00% <100.00%> (ø)`
nldcsc/http_apis/base_class/api_base_class.py	`99.00% <92.30%> (-1.00%)`	:arrow_down:
nldcsc/flask_plugins/flask_eswrap.py	`0.00% <0.00%> (ø)`
nldcsc/flask_midddleware/base.py	`0.00% <0.00%> (ø)`
nldcsc/flask_midddleware/middleware_manager.py	`0.00% <0.00%> (ø)`
nldcsc/flask_midddleware/debug_logging.py	`0.00% <0.00%> (ø)`

P-T-I commented 1 year ago

Could you update the affiliated test as well?

[x] Update http apis test

P-T-I commented 11 months ago

@DionAkkerman Please rebase and add checks for added lines and logic

P-T-I commented 11 months ago

@DionAkkerman ping; is this ready to be merged?

DionAkkerman commented 10 months ago

Ignoring the somewhat harsh code coverage - yes.

NLDCSC / nldcsc

Added support for passing url params through data argument #31

Codecov Report