Closed Thomas-Dolle closed 4 months ago
Attention: Patch coverage is 0%
with 32 lines
in your changes missing coverage. Please review.
Project coverage is 29.07%. Comparing base (
24608eb
) to head (4c63001
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Thomas-Dolle I see no issues with this change; if it reduces the code base from other projects and makes it easier to work with sqlalchemy 2.0; then why wouldn't we use it?
@Thomas-Dolle I see no issues with this change; if it reduces the code base from other projects and makes it easier to work with sqlalchemy 2.0; then why wouldn't we use it?
Fair enough!
Makes use of SQLAlchemy 2.0 models easier across projects by wrapping the Flask-SQLAlchemy default class.
@P-T-I What do you think of putting this in the NLDCSC package? This should reduce the duplication of this code by quite a few times. However, it may create the effect that if a new type is needed this needs to be updated in this package first or on the models own type_annotation_map.
LMK what you think!