NLESC-JCER / QMCTorch

Pytorch Implementation of Real Space Quantum Monte Carlo Simulations of Molecular Systems
https://qmctorch.readthedocs.io/
Apache License 2.0
23 stars 2 forks source link

Infinite Norm with scipy 1.11 #167

Closed NicoRenaud closed 7 months ago

NicoRenaud commented 7 months ago

The factorial2 method of scipy as changed from f2(x<1) = 1 to f2(x<1) = 0. This causes a lot of issues with the norm of the atomic orbitals that then become infinite in some cases.

This happens in python 3.9 that uses scipy 1.11 as default but not on python 3.8 where the default version in 1.10

NicoRenaud commented 7 months ago

fixed by #168