search

NLESC-JCER / cpp2wasm

Guide to make C++ available as a web application
https://nlesc-jcer.github.io/cpp2wasm/
Apache License 2.0
22 stars 6 forks source link

Update pre-commit hook #64

Closed fdiblen closed 4 years ago

fdiblen commented 4 years ago

UID variable in .githooks/pre-commit is a readonly variable on my system.

Renaming this variable ill solve the issue. Related Stackoverflow thread: https://stackoverflow.com/questions/13404665/use-of-read-only-variables-in-shell-scripts

Linux Distro: Arch Linux Bash version: GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)

jspaaks commented 4 years ago

Or use the expression without assignment to a variable, e.g. like here https://github.com/entangled/entangled/blame/d1bce3932d9ced4e40f104bd723f42e32890af12/README.md#L113

Not sure if we should also add the user's group, I'm guessing yes.

jspaaks commented 4 years ago

PR https://github.com/NLESC-JCER/cpp2wasm/pull/68

sverhoeven commented 4 years ago

We could also use https://pre-commit.com/ as a wrapper for a docker command.

fdiblen commented 4 years ago

fixed by #68