search

NLESC-JCER / spectra

A header-only C++ library for large scale eigenvalue problems
https://spectralib.org
Mozilla Public License 2.0
0 stars 0 forks source link

Extend matprod classes #19

Closed v1kko closed 4 years ago

v1kko commented 4 years ago

implements https://github.com/NLESC-JCER/spectra/issues/18

v1kko commented 4 years ago

Scalar is added as a typedef to the matprod classes

codecov-commenter commented 4 years ago

Codecov Report

Merging #19 into master will increase coverage by 0.0%. The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #19   +/-   ##
======================================
  Coverage    92.1%   92.1%           
======================================
  Files          39      39           
  Lines        1595    1610   +15     
======================================
+ Hits         1469    1484   +15     
  Misses        126     126
Impacted Files Coverage Δ
include/Spectra/MatOp/DenseGenMatProd.h 100.0% <100.0%> (ø)
include/Spectra/MatOp/DenseSymMatProd.h 100.0% <100.0%> (ø)
include/Spectra/MatOp/SparseGenMatProd.h 100.0% <100.0%> (ø)
include/Spectra/MatOp/SparseSymMatProd.h 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c1acc79...1a46bc1. Read the comment docs.

felipeZ commented 4 years ago

@JensWehner this PR is ready for review :)

JensWehner commented 4 years ago

tests, please. :)

felipeZ commented 4 years ago

I have also missed the diagonal method

JensWehner commented 4 years ago

If you have an operator double (i,j) you do not need a diagonal method.

v1kko commented 4 years ago

@JensWehner @felipeZ Tests are added now, Also the noalias() does not work for sparse matrices (or so it seems)

JensWehner commented 4 years ago

@v1kko You probably hate me for this but, could you implement a Index size() const method as well for all the classes, which returns the size of the quadratic matrix?

JensWehner commented 4 years ago

sth. in the CMakeLists for the tests is not okay.

felipeZ commented 4 years ago

sth. in the CMakeLists for the tests is not okay.

@v1kko @JensWehner I am going to fix the cmake and add the size method

JensWehner commented 4 years ago

concerning the size() method I was blind. I am sorry. Good work.