search

NLESC-JCER / spectra

A header-only C++ library for large scale eigenvalue problems
https://spectralib.org
Mozilla Public License 2.0
0 stars 0 forks source link

Catch rework #27

Closed JensWehner closed 4 years ago

JensWehner commented 4 years ago

should reduce compile times according to https://github.com/catchorg/Catch2/blob/master/docs/slow-compiles.md#top

yixuan commented 4 years ago

Seems the source file of tests-main is missing?

JensWehner commented 4 years ago

good point

yixuan commented 4 years ago

I think it is ready to merge. The only issue is that this PR does not pass Travis CI since the test takes too long. To fix it we need to add proper optimization flags (e.g. -O2) to the build script. I guess some CMake options need to be modified?

JensWehner commented 4 years ago

yes I took them out because I thought debug should be proper debug mode, but then the tests take 4-5h. github actions can handle it but not travis.

JensWehner commented 4 years ago

Either we make the tests smaller or we add optimisation flags.

yixuan commented 4 years ago

I see. Shall we merge this first and then fix it in the 6_jd_base_solver branch later?