search

NLESC-quantum / quantum_comp

Apache License 2.0
0 stars 1 forks source link

PR for VQLS in Qiskit #33

Closed NicoRenaud closed 2 years ago

NicoRenaud commented 2 years ago

VQLS is now implemented in our fork of Qiskit. We could/should make a PR to have it in Qiskit

NicoRenaud commented 2 years ago

the qiskit devs are not so enthusiastic about vqls. They are therefore lukewarm about the PR ...

broekema commented 2 years ago

Why are they not enthusiastic about vqls and what are the chances of having the PR accepted anyway?

NicoRenaud commented 2 years ago

they think that the algorithm won't be used too much ... they proposed that for now we merge it to qiskit-research https://github.com/qiskit-research/qiskit-research which I think would be nice

broekema commented 2 years ago

Agreed

NicoRenaud commented 2 years ago

Code is here : https://github.com/QuantumApplicationLab/qiskit-research/tree/vqls

NicoRenaud commented 2 years ago

It needs a bit of cleaning, especially the documentation but the rest should be good enough to start the discussion with the qiskit-research people

NicoRenaud commented 2 years ago

After talking with qiskit research people it won't be a good place either. We will keep vqls in qalcore for now. If we want to put our calibration pipeline in qiskit research they would be interested once we published something