NLP-Suite / NLP-Suite

CLICK ON WIKI LINK BELOW OR ON Wiki TAB AT TOP BANNER FOR DOWNLOAD INSTRUCTIONS AND INFORMATION ON THE NLP SUITE.
https://github.com/NLP-Suite/NLP-Suite/wiki
45 stars 18 forks source link

[BUG]: Pop-up notifications are freezing the suite #836

Open natashaemory opened 2 years ago

natashaemory commented 2 years ago

Describe the bug When trying to clear a pop-up message, the countdown to closing and script freeze. Ran into the issue when running special annotators on the Harry Potter corpus.

To Reproduce Steps to reproduce the behavior:

  1. Go to Gender Annotator GUI
  2. Click on "Annotate nouns & pronouns gender" option
  3. "Reminder: CoreNLP exporting Json files pop-up appears", attempt to exit out of it, suite freezes
Frozen Pop-Up

(stuck at 26 seconds)

Desktop (please complete the following information):

This issue occurs in other GUI's as well.

Emory-NLP commented 2 years ago

What do you do exactly when the Yes/No reminder pops up?

natashaemory commented 2 years ago

What do you do exactly when the Yes/No reminder pops up?

Clicking either yes or no results in a freeze

natashaemory commented 2 years ago

What do you do exactly when the Yes/No reminder pops up?

Clicking either yes or no results in a freeze

In this screenshot, I clicked no

Emory-NLP commented 2 years ago

Hard to test since it does not happen on my Windows machine. We will ask tomorrow in class if others have the same experience. Then we can try to find a solution.

Emory-NLP commented 2 years ago

We will look into this issue with Mino. In class, other students showed that the Y/N question stayed on but the code behind kept running. Does this behavior happen ONLY with the Json question?

Emory-NLP commented 2 years ago

Mino, it may be that the only problem is with the code below in Stanford_CoreNLP_util. The CoreNLP code simply keeps running and Y/N do not respond until CoreNLP is done.

# Json_question_already_asked to avoid repeating the reminders question when multiple annotators are used
if (outputDir !='') and (export_json_toTxt and not Json_question_already_asked):
    # check reminder
    reminder_status = reminders_util.checkReminder(config_filename,
                                                   reminders_util.title_options_CoreNLP_Json,
                                                   reminders_util.message_CoreNLP_Json,
                                                   True, silent)
    if reminder_status == 'Yes' or reminder_status == 'ON':  # 'Yes' the old way of saving reminders
        # create a subdirectory of the output directory
        outputJsonDir = IO_files_util.make_output_subdirectory(inputFilename, inputDir, outputDir,
                                                               label='Json',
                                                               silent=True)