#4 Fix linting errors - Githubissues

zeyus commented 1 year ago

Fixes #4 , fixes #8

Removed ipynb files
Cleaned up some unused (not all) functions
Moved out a couple of functions to fix circular dependencies
Indicated with some TODOs where some obvious work could be done
Identified that we need to break things out in a lot of places and there is a HUGE saving to be made in terms of code-reuse, I didn't do that now because it's way out of scope, but there are 100x things i had to change the same code chunks
Addressed keys stored in repo (this still needs further work, expunging)
Fixed all linting issues, with the exception of
- Flask / sqlalchemy "no-member" errors, we can address it later, it just means adding in some stubs
- Unnecessary comprehensions and suggestions to change to sets/lists etc, because no doubt this will be refactored anyway
Added some (super basic) docstrings, but as we go along and refactor stuff we need to flesh them out

✅✅✅✅✅✅✅✅ BUILD PASSING

Suggest we type hint everything we touch from now on as well.

franciscoabenza commented 1 year ago

Just a reminder that here are still some linting issues to be fix related to Flask

zeyus commented 1 year ago

Just a reminder that here are still some linting issues to be fix related to Flask

Yes I'll create a task for it but we can also address it when it comes up after refactoring

NLP4ALL / nlp4all