search

NLP4ALL / nlp4all

NLP4All is a learning platform for educational institutions to help students that are not in data-oriented fields to understand natural language processing techniques and applications.
1 stars 0 forks source link

address gitguardian security issues #8

Closed zeyus closed 1 year ago

zeyus commented 1 year ago

this requires 1 - removing the exposed secrets 2 - removing them from the history and any branches which they appear (slightly complicated) 3 - doing the same in the upstream repo https://github.com/arthurhjorth/nlp4all (which hopefully will be defunct at some point once github detaches the fork)

zeyus commented 1 year ago

this also will have to be approached a little differently and very carefully, it can't be done by creating a new branch because it requires destructive changes to the repo history

zeyus commented 1 year ago

It's all done on this repo, but I don't have permissions to do it on the original repo.

zeyus commented 1 year ago

@arthurhjorth this may be something you want to do. I have a list of the secrets that were in the repo and I used the "BFG" tool as outlined here: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/removing-sensitive-data-from-a-repository

arthurhjorth commented 1 year ago

Oh man, I could have sworn that I kept my secrets uncommitted and out of the repo. I guess I made a lazy git add all at some point and included them. Thanks for the heads up!