making numpy 1.16.1 a minimum requirement, not a hard dependency

NLPatVCU / medaCy

:hospital: Medical Text Mining and Information Extraction with spaCy

GNU General Public License v3.0

432 stars 91 forks source link

Closed sema4-EricSchles closed 5 years ago

sema4-EricSchles commented 5 years ago

type: refactor files added: none description: making numpy 1.16.1 a minimum requirement, rather than pinning to that dependency version

The reason for this change is textacy requires numpy == 1.17 (approximately) at least. So by making 1.16.1 a hard requirement I cannot install both.

sema4-EricSchles commented 5 years ago

It seems I cannot assign this to myself, please let me know if you have any concerns.

sema4-EricSchles commented 5 years ago

@bmcinnes @AndriyMulyar @CoreySutphin @jvargas2

swfarnsworth commented 5 years ago

Apologies for the delay in addressing this concern. Please let us know if you if you have any questions or feedback going forward.

sema4-EricSchles commented 5 years ago

No worries! @swfarnsworth thanks for your work on this project! It looks very promising!