search

NLPatVCU / medaCy

:hospital: Medical Text Mining and Information Extraction with spaCy
GNU General Public License v3.0
432 stars 91 forks source link

Convert the config JSON to a YAML file #200

Open swfarnsworth opened 3 years ago

swfarnsworth commented 3 years ago

YAML files appear to be better suited for storing configuration data than JSON.

-Config file -- Should be converted to a YAML file. -Config reader -- This should probably be deleted and we can let a library like PyYAML handle what this module is for.

vmdhhh commented 3 years ago

We can convert the JSON to YAML and just modify the Config reader to read YAML config rather than deleting it right? What do you think @swfarnsworth ?

swfarnsworth commented 3 years ago

@vmdhhh That's certainly an option, though the config reader that we implemented isn't widely used and if the PyYAML library does everything we'd need (and it's possible that it doesn't--I haven't done that exploration), I figure that in general we should reduce how much meta-functionality this package has.

vmdhhh commented 3 years ago

@swfarnsworth For now, AFAIK the Config reader module is only getting used in Pipeline components and Get Metamap . So changing config JSON to YAML and including pyYAML into Pipeline components and Get Metamap would be enough right? If yes, I can try to do it. Let me know.